wordpress soft rejection

wordpress

#1

Howdy all

Got our theme rejected again, Seems like there is always new things added to each rejections. Getting really frustrated with this. Anyhow here is what the reviewer said:

Soft Rejected

Leftovers from previous reviews and new additions:

  1. WordPress trademark requires a correct spelling of the name, with capitol P.
  2. Prefix everything and use unique (theme-name-based) consistent slugs. Additional prefix is acceptable for when the author is using a framework. Avoid using initials or abbreviations. Here’s a list of the most common things that should be prefixed: PHP function names, PHP class names, PHP global variables, Action/Filter hooks, Script handles, Style handles and Image size names. Please see: http://themereview.co/prefix-all-the-things/
  3. The text domain must match the slug of the theme. If your theme’s name My Theme is defined in the style.css or it is contained in a folder called my-theme the domain name should be my-theme. The text domain name must use dashes and not underscores. No constants (variables), it should be a hardcoded string instead.
  4. Always use esc_url when sanitizing URLs (in text nodes, attribute nodes or anywhere else). Rejects URLs that do not have one of the provided whitelisted protocols (defaulting to http, https, ftp, ftps, mailto, news, irc, gopher, nntp, feed, and telnet), eliminates invalid characters, and removes dangerous characters.
  5. Translate all strings and escape where needed. JS and TGMPA included. You need to use a text domain to denote all text belonging to that theme. The text domain is a unique identifier, which makes sure WordPress can distinguish between all loaded translations. This increases portability and plays better with already existing WordPress tools. Any strings within a PHP variable requires to be translated. https://developer.wordpress.org/themes/functionality/internationalization/
  6. Don’t use this please: http://envato.d.pr/16pCn/1CZyHpc0 it is not safe.
  7. global variable should be used restrictively and only if theme really needs to. Here’s an example how this would be acceptable: http://envato.d.pr/1aT9P/3ageodpz It’s highly recommended not to use them at all just to keep things out of the global namespace, they’re not so good coding practice.
  8. Don’t include widgets like this: http://envato.d.pr/dAUZ/8Kdke8Lt http://justintadlock.com/archives/2010/11/17/how-to-load-files-within-wordpress-themes
  9. Sorry, but this isn’t allowed: http://envato.d.pr/RCx/Y0Nys2DI
  10. All plugins should be up to date.
  11. Always use esc_url when sanitizing URLs (in text nodes, attribute nodes or anywhere else). Rejects URLs that do not have one of the provided whitelisted protocols (defaulting to http, https, ftp, ftps, mailto, news, irc, gopher, nntp, feed, and telnet), eliminates invalid characters, and removes dangerous characters.
  12. All scripts and styles (including comment reply) should be added from functions file and hooked with wp_enqueue_*, don’t hardcode them or include them directly, like in header.php, footer.php, etc. https://github.com/Automattic/_s/blob/master/functions.php#L113-L127
  13. Tracking, analytics etc are plugin-territory, please remove them. Don’t forget to run Theme Check as well https://wordpress.org/plugins/theme-check/ Please check everything carefully, not fixing the issues or fixing them partially will delay your final approval. Good luck!

Anyone have some ideas or had the same rejection notices.

Cheers

Lester


#2

NOW THIS IS SOFT REJECT … You know what I got?

"1) Usability, 2) Readibillity, 3) Overall quality " - that reviewer wrote and that’s it.

Which reviewer? I will send him congratulations for work.


#3

Yeap! that’s the way to give a feedback. Not to give 1 point at a time :slight_smile: and then the next and so on.You skipped 12 soft rejections! Try to step into every point and fix as requested. Good luck!


#4

Its happening to all. Happy & Healthy Submissions


#5

13 soft rejected reasons is too much but you should be happy because these are WP code technical and could be easily improved, a good WP developer would know how to improve them.

Good luck in next submission.


#6

Hey there well yes soft reject because we are passed the usability, readability, overall quality, so these are not major things but by the sounds of it your issues are major things. We first submitted our theme in december so its been 3 full months of back and forth submissions and rejections but the issue is that 4-5 reviewers were saying different things and it was hard to figure out what they wanted because a lot of things were not on the submission requirements by envato so we did not know. Now we know after 3 months. The rest of the rejection notices were pretty vague.

Cheers

Lester


#7

So I should get hard reject … of course I delete item because it was impossible to fix.


#8

Over all quality is a major thing brother. That means that the reviewer did not even look at your code. Just the live site and he did not like it for the reasons he gave you. which are vague but there must be a lot of things that are not up to their standards.

Cheers

Lester


#9

soo again, it should be hard reject … so I can count 14 hard reject WP and 3 soft :slight_smile: every soft reject was very “automatic”. 17 themes almost 1 year lost :slight_smile: Have someone more ? :smiley: now waiting for 18th theme , probably it will be 18th reject and that;s my last try.


#10

@WordicaThemes do not loss hope. you just have 17 and i can’t count how much I have lost. Yesterday, I got soft and then hard, but still hopeful and will try my next one with my full strength.
And I know hard work will not lost.
So cheers :slight_smile: :smiley:


#11

All i can say is dont give up, I see a trend with some of the new reviewers and they are going beyond the envato guidelines but one way its good. It also can be a pain in the rump fo authors but the end result will be better. So just keep on working on it. Btw do you have a link to your file i can maybe give you some ideas.

Cheers

Lester


#12

It’s easy to say … don’t give up. But I must live ,I must have money :slight_smile: I’m freelancer had some income but creating for TF take much part of my time.


#13

Hi Nitro, did you manage to go through ?.. what did you do with this:
add_filter(‘widget_text’,‘do_shortcode’);

I have similar code… but again its “plugin territory”… and what about filtering P tags…

I have almost similar list but it was a bit long, I had 21 points :slight_smile: … I believe these will be last… as they look minor…


#14

Wow man, that’s tough going :frowning: Perhaps you should take an incremental approach to save time and effort?

You should consider building and submitting a Marketing Landing page (Marketing > Landing pages). They are plain HTML (You can add PHP for forms etc) and the review process is much easier and faster, no WP issues etc. I’ve gotten 2000+ sales from the section. This will help you validate a design, which you can then expand on and submit in the HTML templates section down the line. Once you get through the HTML templates approval process you can implement it as a WP theme with a better chance of not receiving a hard reject. This process is called double dipping and is allowed.

Doing this will fast track the process and allow you to focus on getting through a good design without spending many days/weeks mucking about with WP.

Just a suggestion, all the best!


#15

I had few landing page accepted in here … it’s impossible to make money on them. Right now even on WP it’s impossible with more then 30 days review time…


#16

My theme got soft rejection can anyone please tell me how to fix

  1. WordPress trademark requires a correct spelling of the name, with capitol P. (what he is talking about a string? then where )

2: Theme Check issue: http://envato.d.pr/1k32P/sOVs9WsE


#17

I got a similar one to #2 the other day. On the TGMPA website you can download a custom build of the plugin specifically aimed at ThemeForest themes. You should do that


#18

thanks for tip. waiting for #1 now.


#19

That’ll just be writing WordPress like that < instead of wordpress, Wordpress or word press, that kind of thing.

There must be somewhere in your theme where it’s not written WordPress?


#20

Using the themeforest version of TGMPA may get you rejected. The Wordpress.org one is more accurate to requirments. That was my experience anyway. But it still had to be modified to completely fit, but it was less work to adjust the .org one then the themeforest one.