I got Soft rejection of my Codeigniter application. Here is the comments from the review team:
- Please make sure the code adheres to PSR standards.
- Make sure that the code doesn’t raise any PHP errors, notices or warnings. Please set error_reporting(E_ALL)
- Please double check for common security vulnerabilities: SQL injection, XSS, CSRF etc
- Please make sure the item doesn’t contain any encrypted code or a third party licensing system.
The documentation is a little lacking.
Most importantly, remember that buyers may not be technically inclined. They may just be looking for an item to drop into their existing code base. Also keep in mind that a typical user won’t really know about all the features your system brings to the table. With them in mind, you should also look into providing a quick start guide of some sort. It need not be long: a short one will do.
You can use a premade template or the Documenter tool for your documentation, both linked below:
Here is my comments and opinions:
I’m using Codeigniter framework and my methods are constructed like with dash. Ex. add_new_client. Should i revert all of them to addNewClient ? Or this is only the automated message. I also have some html in my controllers which i think this is more the problem then the method names. Also all my functions are commented with @params, @return and short description. And i have some private classes starting with _, do you think this can be the problem also for PSR?
I will check for php errors.
SQL Injection not possible, all $_POST data a gathered from the framework functions.
I double checked all my third party scripts and i dont have any encrypted code or third party licencing system. How can i assure this?
And yes i should fix the documentation.
Any help and suggestion will be welcomed.
Btw this is my first Codecanyon submission.