hello guys i don’t understand what say reviewer…
here the reviewer mention reason…
-
CACHE JQUERY OBJECTS: Please cache the jQuery objects that are used more than once when it’s possible, this will help a lot with performance of the site. --> http://envato.d.pr/7xEJ
-
STRICT EQUALITY COMPARISON: For better performance please use Strict Equality Comparison. --> http://envato.d.pr/7xEJ
plz help me how can i solve it…and see my code it is right or wrong
my previous code is
/*---------------------------- OPEN SEARCH FORM ----------------------------*/ $('.search-form-trigger').on('click', function (event) { event.preventDefault(); toggleSearch(); }); function toggleSearch(type) { if (type == "close") { //close serach $('.search-form').removeClass('is-visible'); $('.search-form-trigger').removeClass('search-is-visible'); } else { //toggle search visibility $('.search-form').toggleClass('is-visible'); $('.search-form-trigger').toggleClass('search-is-visible'); if ($('.search-form').hasClass('is-visible')) $('.search-form').find('input[type="search"]').focus(); $('.search-form').hasClass('is-visible') ? $('.search-form-overlay').addClass('is-visible') : $('.search-form-overlay').removeClass('is-visible'); } }
and i am right now fix it…look see blew…and tell me it’s right or wrong
/*---------------------------- OPEN SEARCH FORM ----------------------------*/ $('.search-form-trigger').on('click', function (event) { event.preventDefault(); toggleSearch(); }); var searchForm = $('.search-form'); var searchFormTrigger = $('.search-form-trigger'); function toggleSearch(type) { if (type === "close") { //close serach $searchForm.removeClass('is-visible'); $searchFormTrigger.removeClass('search-is-visible'); } else { //toggle search visibility $searchForm.toggleClass('is-visible'); $searchFormTrigger.toggleClass('search-is-visible'); if ($searchForm.hasClass('is-visible')) $searchForm.find('input[type="search"]').focus(); $searchForm.hasClass('is-visible') ? $('.search-form-overlay').addClass('is-visible') : $('.search-form-overlay').removeClass('is-visible'); } }
if find here any wrong plz tell me how can i solve it…