How to fix problems - soft-rejected

Envato Authors Theme Authors
,
1

I have review - but i don’t know what change
help please

http://deximlabs.com/dexjobs/

PROPER EVENT BINDING: Consider using the preferred .on() method rather than .click(), .bind(), .hover(), .load(), .ready(), etc. For best performance and concise code use event delegation whenever possible: https://codepen.io/32bitkid/post/understanding-delegated-javascript-events

- http://envato.d.pr/j3jg

2

Hi,

You need to modify your code. What does this mean?

###For example if you have .click function

$('#whatever').click(function() {
     /* your code here */
});

####You need to use:

$('#whatever').on('click', function() {
     /* your code here */
});

And same concept for all your functions.click(), .bind(), .hover(), .load(), .ready()

Check this stackoverflow post to see difference between .on(‘click’) vs .click()

The idea is to optimize your code for faster page loading.

3

Thx it’s help me :slight_smile:

i have another bug

CACHE JQUERY OBJECTS: Please cache the jQuery objects that are used more than once when it’s possible, this will help a lot with performance of the site.

do you have solutions?

4

Take a look here: http://jsperf.com/why-cache-jquery-selectors

3 Likes