WordPress soft rejected , some tips about reviewer's msg?

Hi all,
I have some problems to understand reviewer’s msg.
First, Reviewer 1 sent something to correct - done
Then Different reviewer sent something to do - done
Again first said something different - done
Again other reviewer sent something to correct regarding suffix - done
And i think last reviewer (that is first) ask this:


https://envato.d.pr/SNXqxi

Can somebody advice me what is wrong?

Thanks

1 - Rename your child theme function to payton_styles() instead of layers_payton_styles()

2 - Rename theme folder inside your uploaded package to payton-theme instead of Theme

Thanks.
He don’t want to understand… Correct way for 1 is like this.
Is after layerswp doc… I will try again because this was made before last time, and other reviewer ask to change.

Thanks

PS. On wordpres do you saw something on update?
The example, I corrected my tags and after 2 days not still aprouved and is strange. Also support not responding. Did you saw something like this?

It’s Sunday today so don’t except to get a response.

1 Like

Thank you,
Is the same …

Your theme appears to be in the wrong directory for the theme name. The directory name must match the slug of the theme. This theme’s correct slug and text-domain is payton-wordpress

What’s inside payton-wordpress folder ?

In this folder I have my theme named Payton.
This should rename to payton-wordpress?
And the example. Where I have write payton, în my function.php to rename it to payton-wordpress?

Why do you have theme folder inside other folder ?

To change your theme slug/text-domain you need to change this in all your theme files not just functions.php file this is not hard you can use any code editor to make search and replacement across all the files.

Hi, I saw this on many themes on themeforest, so I made like them.
I made ok now.

Problem is with naming.
In first I made all with my theme s name.
One reviewer said to modify and show me what to delete and is like in img.

Now other reviewer said that is not OK what other reviewer said… So I’m confused, someone sa is something, other sais something different…
Can I have your help?

Naming is still not appropriate:

https://envato.d.pr/yN11Cy

Name the scripts and styles handles correctly.

If the file you’re including is called example.js, Example.js your handle will be themename-example, which means always must be a lowercase. You can use - or _ only. Vendor libraries don’t need a prefix but the naming practice remains identical.

This was previous msg
https://envato.d.pr/n2aO60
Then they recommend to be payton-wordpress and to remove where is with arrow…

  • Don’t prefix theme plugins so if any other plugin is re-queuing bootstrap for example don’t load twice… This is the reviewer point.

  • Don’t use get_stylesheet_directory_uri() this way if the user activated child theme it will raise an error unless you include the assets files in your child theme.

Include the full message to understand more.

Hi,
Yes, but bootstrap file is not prefixed.
This theme is based on layerswp theme framework so using this, we can build only child themes and get_stylesheet_directory_uri is the only way to to include some file in child theme. Is after official documentation. If you use default include function, this mean that you will include file from parent and in our case, you need to include from child not parent.

Full msg
Naming is still not appropriate:

https://envato.d.pr/yN11Cy

Name the scripts and styles handles correctly.

If the file you’re including is called example.js, Example.js your handle will be themename-example, which means always must be a lowercase. You can use - or _ only. Vendor libraries don’t need a prefix but the naming practice remains identical.

Good practice examples:

Also see: http://themereview.co/prefix-all-the-things/

Why bootstrap is named font-bootstrap ?

I don’t want confuse you more but in a proper way for theme development it’s not recommended to enqueue the minfy version of the file unless you check WP_DEBUG is not enabled otherwise it will be pain to debug your assets files.

My advise if you want learn look at the core WordPress themes first and then you may watch the other themes.

Maybe this is an issue font - bootstrap…
I saw he is as default named like this in parent theme.

So correct is bootstrap not font bootstrap.
And is ok to have bootstrap for css file and bootstrap for js?

This is different then normal theme, like a theme made with redux the example.
No errors in theme. All good, I think reviewer are talking about that font bootstrap and should be simple just bootstrap

Thanks

Hi,
Thank you for your help.
Theme is aprouved

Cheers and good luck.

Congratulation :slight_smile:

1 Like