Theme Check - issue with Woocommerce


#1

Hello, I ran a test with the Theme Check plugin on the theme I’m working on now and here’s what I got:

WARNING: Found a translation function that is missing a text-domain. Function _e, with the arguments 'View your shopping cart'
WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'woocommerce'
WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'No products found'
WARNING: Found a translation function that has an incorrect number of arguments. Function _n, with the arguments '%s download remaining', '%s downloads remaining', downloads_remaining, 'woocommerce'

The thing is that I’m modyfying Woocommerce templates and for this sake I copy-pasted the template files as advised to avoid losing my changes after Woocommerce update.

Now what should I do with these warnings? Should I leave them the way they are or try to modify them? Will these warnings result in my theme being rejected?


#2

You should use only templates you are modifying in your theme, so if you copied the entire templates folder from WooCommerce plugin you should consider using only important ones, as I said before.

Now, if you don’t make all strings translatable you will have problems in future when customers will try to translate your theme. So you should make them translatable.

My suggestion is to use “Pig Latin” plugin. This way you will easily see what strings are not set to be translatable.

Good Luck!


#3

Ok, that sounds like a plan. Thanks!