We’re having a bit of trouble getting a theme approved. We’ve gone through several rounds of soft rejections (as can be expected) for small changes. However, the final soft rejection reason I don’t quite understand and while I’ve asked repeatedly for clarification from the reviewer, I get nothing in response.
- http://envato.d.pr/HyKOJF/2gmTYRdP Theme should work out of the box and it should carry the styling from one of the demo you have.
Kirki is used as the options framework for the the theme and is not activated here, but the theme functions just fine without it and lives up to the theme unit test data standards (the reviewer is aware of this based on screenshots provided). The theme default CSS also is styled using the base styles from one of the demos.
I realize the screenshot does look very plain since they only have the Theme Unit Test data imported and no logo or menu has been added. But in my experience, most themes look very generic under this data and you can’t expect a WP index page to replicate a demo. Here’s a screenshot of the demo data to show featured images and menus are working as well as a couple of our demos:
There are 6 different grid styles available in the theme, but we switched the default style to one that displayed more standard WP features (excerpt, featured image, more ‘normal’ styling, etc).
Is the implication that we should set force_activation on TGMPA for our theme options?
Are they asking that we embed plugins directly in the theme? I hope this is not the case as this is very bad practice, but I’m afraid this is what’s really being asked of us.
Should we use the theme logo in place of the blog title in the navigation menu? Again, does not seem like appropriate theme behavior.
Or are they saying that we should be forcing an import on demo data on theme activation? This is available with a 1 click install currently. Forcing a demo import seems really unacceptable for theme behavior, not to mention there are 15 demos to choose from. Doing this would also create issues for users with existing site content.
Sorry for the wall of text and thanks in advance for any insight anyone can provide.