Soft rejection advice please

wordpress

#1

Hi guys,

I’ve got a soft rejection on my theme and I don’t think that I understand few tasks.

1. Some of your files contain validation errors that will need to be fixed. Please be sure that all files validate before resubmitting.You can validate HTML at validator.w3.org

- There are quite a few validation for the plugins used – as Visual Composer, Utimate Addons, Revolution slider. This comment refers to them as well?

2. All JavaScript should be written with “use strict” mode on. For example, you can do this with jQuery as follows:

(function($) {
“use strict”;
// Author code here
})(jQuery);

Does this comment refers to the vendor scripts as well?

3. Custom Post Types are plugin territory. Read more at: justintadlock.com/archives/2013/09/14/why-custom-post-types-belong-in-plugins

My theme use Custom posts types for: portfolio, testimonials, clients, staff
I saw on themeforest many themes that did the same.

4. Weak hierarchy. http://envato.d.pr/1lqjj/4XPproJQ

This is my theme


#2

1, if possible try removing those otherwise just write it down in the reviewers message.
2, Best to alter all JS files.
3. Yes make it into a plugin
4. Self explanatory


#3

hi @drsankarl thank you for the reply,

regarding point 4. Weak hierarchy. http://envato.d.pr/1lqjj/4XPproJQ

What shall I do there? I don’t understand what I have to do. can you please advice me?

Thank you


#4

I cant locate that page in your demo.
The below page has correct visual hierarchy with bold post title etc.
http://webuild.redbee.pro/blog-image-post/


#5

@pro_advertise
i’ve 1, 2 and 3 soft rejection to, i’ve crawl every library moving and change the code, the most confusing is tgm plugin installer admin menu hook (it get theme check warning) i’ve no clue at all,

it’s the only way, finaly my theme get accepted :smiley:


#6

@pro_advertise Visual Hierarchy


#7

@pro_advertise: have vertical scroll on your layout https://monosnap.com/file/E2HBhMOQnN5k3jd75vA5UkkVssMYBt#