Soft Reject few of the point

wordpress

#1
  1. After theme is activated I create custom table in database for newsletter. I understand that I can’t do nothing like that with database? Please don’t do this http://envato.d.pr/1edkr/5yPaEh3B
  1. The localization file should be in English and delivered as .POT file. .POT will contain all translation strings - but PoEdit do not create .POT file, only .po …
  1. Third party scripts/ styles don’t need to be prefixed to avoid double loading. ref:

#2

Bit unclear if your sharing rejection reasons to help others or if your looking for help


#3

I’m looking for help - especialy about 3 point. I do not understand it.


#4

3 item is that scripts that are not written by you shouldn’t be prefixed. Ie enque_script(‘select2’, not enque_script(‘theme_select2’


#5

1.) you should put that into plugin. BTW. Using existing 3rd party newsletter plugins is IMHO much better approach, unless you are offering something specific with your own implementation

2.) Read this to learn difference between .PO and .POT
https://www.icanlocalize.com/site/tutorials/how-to-translate-with-gettext-po-and-pot-files/
You can just rename .PO to .POT

3.) Hard to tell from this screenshot, please share screenshot with full lines. But it’s as @Zorbix said


#6

1,2 - thanks

3- reviewer do not provide full screenshot but I add this like that:

wp_register_script( ‘script-1’, get_template_directory_uri() . ‘/inc/js/jquery.colorbox-min.js’, array( ‘jquery’ ),’’,true );
wp_enqueue_script( ‘script-1’ );


#7

Since it is a 3rd party script, try to name it just as “jquery-colorbox”. Same for all 3rd party scripts.


#8

Ok thanks so filename == name


#9

Pretty much