Soft Reject, Explain More please

wordpress

#1
  1. Favicons are now part of WordPress, it’s recommended not to include on your own.

How we can implement it that?

Second Issue :

  1. Any item in header/footer area that is a function should be moved
    into functions file. Otherwise theme might have issues when users
    overrides with custom templates via child theme.

How we can solve this ???


#2

Check favicon option appearance > customize


#3

Add in your header.php <head> section
if (function_exists( ‘wp_site_icon’) && has_site_icon()) {
echo ‘’;
}

You can provide a default favicon image in else condition


#4

can we use it that way

<?php
        // If WP4.3+ and no site_icon is set - show custom
        if ( function_exists( 'has_site_icon' ) && !has_site_icon() ) { ?>
                
        <?php }
        // If before WP4.3 - show custom
        if ( ! function_exists( 'wp_site_icon' ) ) { ?>
            
    <?php } ?>

#5

Hi, I think a more accurate implementation would be:

<?php
        // If WP4.3+ and no site_icon is set - show custom
        if ( function_exists( 'has_site_icon' ) && has_site_icon() ) {
         wp_site_icon();
        } else { //fallback for 4.5 and below ?>
            
      <?php } ?>