Interesting Soft-reject reason.

Envato Authors Theme Authors
,
1

Hello everyone,

One hour ago I’ve got this rejection reason:

  1. All theme text strings need to be translatable: http://envato.d.pr/15heG/1yXEorsw

This is the code from the array of plugins to be installed using TGMPA.

Can someone clarify one thing: why do I need to make this string translatable? I.e. why do I need to translate Mercedes to other languages? :neutral_face:

2

Agreed. “Twitter”, “Facebook”, “Linkedin” must be translatable as well I guess :smile:

3

I can very much see your point but consider this: how would a Hebrew speaker spell “Mercedes”? It would be “מרצדס”. This is true for many other language not using English letters.

4

But in our situation we don’t need to translate these strings. There is no reason for this. Really. Plugin name, in this case, like a trademark.

6

same issue , What’s new ?

7

You should do what reviewer says (if you need to approve your theme) :wink:

8

and what about abspath function in tgm ?

9

Could you be more clear?

10

they sent me this message about abspath function in tgm :

 Theme needs to properly load files. There are several functions available for getting the path:
 - get_template_directory(): Returns the absolute template directory path 
 - get_template_directory_uri(): Returns the template directory URI 
 - get_stylesheet_directory(): Returns the absolute stylesheet directory path
 - get_stylesheet_directory_uri(): Returns the stylesheet directory URI.
11

And you don’t know which one you need to use?
Tip: - get_template_directory(): Returns the absolute template directory path :wink:

12

ABSPATH returns the absoloute path of the wordpress installation .
get_template_directory it’s not the right alternatif :confused:

13

Buddy, if you know more than me, then why you asking your questions? :smirk:

Once again. If you need to install a plugin within your theme using TGMPA, then you should use get_template_directory()

I.e.

array(
            'name'               => esc_html__( 'My Meta Boxes', 'textdomain' ), // The plugin name.
            'slug'               => 'pretty-awesome-meta-box', // The plugin slug (typically the folder name).
            'source'             => get_template_directory() . '/inc/plugins/pretty-awesome-meta-box.zip', // The plugin source.
           .............
        )
14

i ask you because i want to know if they asked the same things to you too .
and because ABSPATH can’t be replaced with thoses functions in their message .
that’s why .
thanks for your snippet .

15

No, because I don’t use ABSPATH instead WordPress functions :wink:

OK. Good luck with approval :joy:

16

ABSPATH is included with tgm in this file : https://github.com/TGMPA/TGM-Plugin-Activation/blob/develop/class-tgm-plugin-activation.php

same issue : https://github.com/TGMPA/TGM-Plugin-Activation/issues/616

Good luck for you too and thanks again :slight_smile:

17

Ahh… that’s better. I’ve assumed that you talking about installing plugins. How did you include tgmpa file into your theme?

18

By adding a require_once call in functions.php referencing the class file.

19

require_once get_template_directory() ?

20

Yes

require_once get_template_directory() . ‘/tgm/tgm.php’;

21

Hmm…interesting. Seems like a new reviewer.
Re-submit your theme with note to the reviewer and cross your fingers :grinning: