help for soft rejected wordpress theme

Envato Authors CodeCanyon
1

hello all,

i have got a soft reject on my theme

one of the points says :

Data Validation issues have been found in your theme. All dynamic data must be correctly escaped for the context where it is rendered. - All dynamic data must be escaped with esc_attr() before rendered in an html attribute. - Whenever you are rendering a url to the screen its value must be passed through esc_url() first. - If dynamic data is rendered inside an attribute that triggers a JavaScript event, it must be escaped with esc_js(). For examples and there are more: http://envato.d.pr/11NY1/1apkC7ev

the function window_ads() in the image is used to print the advertisement system in the magazine

function window_ads( $ads_id, $before = false, $after = false ) {
$control = window_get_setting( 'banner_box' . $ads_id . '/gadget' );
if ( 'code' == $control ) {
	if ( window_get_setting( 'banner_box' . $ads_id . '/code/code_block' ) ) {
		echo $before;
		echo do_shortcode( htmlspecialchars_decode( window_get_setting( 'banner_box' . $ads_id . '/code/code_block' ) ) );
		echo $after;
	}
} elseif ( 'image' == $control ) {
	if ( window_get_setting( 'banner_box' . $ads_id . '/image/img' ) ) {
		$target = $nofollow = false;
		if ( window_get_setting( 'banner_box' . $ads_id . '/image/tab' ) ) {
			$target = true;
		}
		if ( window_get_setting( 'banner_box' . $ads_id . '/image/follow' ) ) {
			$nofollow = true;
		}
		echo $before;
		?><a href="<?php echo esc_url( window_get_setting( 'banner_box' . $ads_id . '/image/url' ) ); ?>"
		title="<?php echo esc_attr( window_get_setting( 'banner_box' . $ads_id . '/image/alt' ) ); ?>"<?php if ( $target ) { ?> target="_blank"<?php } ?><?php if ( $nofollow ) { ?> rel="nofollow"<?php } ?>>
		<img src="<?php echo esc_url( window_get_setting( 'banner_box' . $ads_id . '/image/img/url' ) ); ?>"
		     alt="<?php echo esc_attr( window_get_setting( 'banner_box' . $ads_id . '/image/alt' ) ); ?>"
		     class="img-responsive"/>
		</a><?php
		echo $after;
	}
}

}

so i have validated all data!

what should i do with this ?!

demo link: Window – A Great Newspaper Theme

any help would be appreciated ,
thank you.

1 Like
2

hello, anybody can help ???