donee


#1

this is review message.

  1. PROPER EVENT BINDING: Consider using the preferred .on() method rather than .click(), .bind(), .hover(), .load(), .ready(), etc. For best performance and concise code use event delegation whenever possible: https://codepen.io/32bitkid/post/understanding-delegated-javascript-events
  1. INDENTATION: please make sure that your code it’s correctly indented, here in Envato we are committed to deliver the best product possible.

Soft Reject proper event binding & spacing and alignment. pls help me
#2
$('#divID').on('scroll',function(e){
   //your codes
});

Change your jQuery codes as above for all methods ( .click(), .bind(), .hover(), .load(), .ready(), etc )


#3

what is this INDENTATION: please make sure that your code it’s correctly indented, here in Envato we are committed to deliver the best product possible.


#4

http://jsbeautifier.org


#5

?? fix all


#6

where i need to change


#7

This part you need to modify:


#9
$(window).on('scroll', function() {
	if ($(this).scrollTop() > 500) {
	$('.scrollup').fadeIn();
	}
	else {
	$('.scrollup').fadeOut();
	}
});

#10

need any code to change using .on @ki-themes


#11

This part looks fine. If you have another JQ file, check that, too


#12

okay thank you very much :slight_smile: