Been soft rejected again and again for almost same reasons

wordpress

#1

Hi there,

I’m getting soft reject on my WordPress theme again and again. Reasons are technical.

I’m using Codestar Framework in my theme. Which have problems with textdomains. Also using lessphp to compile css from less. It uses file_get_contents() and file_put_contents() which triggers error in theme check.

I always collect free files each month. Test them with theme check. And the result I see, it always surprises me. Their framework has thousands of errors, warnings, recommends and infos. Also some themes has error inside code without any framework. How they got approved when I couldn’t?

In the message to reviewer field, I’ve mentioned what I’m using and what errors they give me in theme check.

Eventually I get soft reject and they ask me to fix errors from the frameworks I’m using.

Codestat Framework,
Shows error with textdomain, ‘add_menu_page’ and ‘add_submenu_page’. They says I need to fix them.

Less compiler,
Shows error with file_get_contents() and file_put_contents(). They says I have to use WP_Filesystem instead.

Screenshot: http://envato.d.pr/1aW1R/gjwqSJqy

Ok, I’ve fixed all of them and resubmitted. Now again got a brand new soft reject message, with 6 issues.

I’ve figured out most of them. Now problem with a few things.

Theme needs to properly load files. There are several functions available for getting the path:

get_template_directory(): Returns the absolute template directory path.
get_template_directory_uri(): Returns the template directory URI.
get_stylesheet_directory(): Returns the absolute stylesheet directory path.
get_stylesheet_directory_uri(): Returns the stylesheet directory URI.

and

Include files via get_template_directory() and not with locate_template because you’re not loading WordPress templates and core is very specific when it comes what is loading.

I know these issues are from the frameworks I’m using. The codestar framework has a function called cs_locate_template() and they don’t use get_template_directory() or get_stylesheet_directory() to load files.

Now what should I do about this?

Also there one more issue I’m facing. For last 3 rejection I’m getting this:

Data Validation issues have been found in your theme. All dynamic data must be correctly escaped for the context where it is rendered.

  • All dynamic data must be escaped with esc_attr() before rendered in an html attribute.
  • Whenever you are rendering a url to the screen its value must be passed through esc_url() first.
  • If dynamic data is rendered inside an attribute that triggers a JavaScript event, it must be escaped with esc_js().

Now, I’ve checked line by line, all datas are escaped. But reviewer still says this. Is there any proper way for me to troubleshot the data validation issues? or how do I know that my theme has data validation issues?

Thanks in advanced.


#2

I think you should add framework as a plugin to pass theme check issues.


#3

But I see that most of the themes on TF, has framework included in theme itself. They also trigger some errors.


#4

same problem but I have been improving whatever they saying even after 8 soft rejections now.

So we need to be consistent & positive as they are doing this because it is beneficial in order to improve the quality for the buyer and we will net give less support with more sales.


#5

i want to ask this question too !!


try to use redux framework for theme options and cmb2 for metaboxes or use unyson frame work


#6

Since you are still in soft reject state then it means your doing good. It’s a good progress. You have to pass on different tests until you fix all these issues. Same thing happened to us on or previous WordPress theme. So just keep up fixing the issues

Good Luck


#7

Free files are not recent ones. As far as I know, theme check standards are strict from last <10 months. Till that time even redux explanation was accepted. now it isn’t ( except a rare case :wink: )

Not possible now a days :slight_smile: . Are you sure those are recent ones?


#8

You must include the framework as a plugin with TGM class otherwise you will keep working for months with soft rejections. Do not compare the things with other themes you have downloaded from free file of month. The rules are now totally changed there is a huge difference in my first theme and the latest theme. I would suggest you to just add your framework as plugin and all your errors will be fixed.


#9

Let’s see. I’m already at my 9th soft rejection. I can get a result today or tomorrow. If I still get soft rejection, I’ll try to include framework as plugin.